Enhance Metadata Generation with "Used By" Tracking#774
Open
0xHericles wants to merge 3 commits intomainfrom
Open
Enhance Metadata Generation with "Used By" Tracking#7740xHericles wants to merge 3 commits intomainfrom
0xHericles wants to merge 3 commits intomainfrom
Conversation
tlgimenes
reviewed
Aug 15, 2024
engine/decofile/fsFolder.ts
Outdated
| if (key === "__resolveType" && typeof value === "string" && !isRoot) { | ||
| const blockName = value.split("/").pop(); | ||
| if (blockName) { | ||
| const blockPath = Array.from(blocks.keys()).find((path) => |
Contributor
There was a problem hiding this comment.
isso aqui nao é lento nao? criar um array dos e fazer um find para cada prop de cada block, ainda mais recursivamente assim?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the metadata generation process by introducing a
usedByfield to track where each saved block is utilized across the projectKey Changes:
usedByTracking: Added logic to identify and record references between saved blocks, updating the metadata with this information.Example (from
blocks.json):{ "/.deco/blocks/Footer.json": { "blockType": "sections", "__resolveType": "site/sections/Footer.tsx", "usedBy": [ "/.deco/blocks/pages-test-3c04f2690620.json", "/.deco/blocks/pages-home-5afd25174424.json", "/.deco/blocks/pages-testing-a5c1b57018a9.json" ] } }